Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs: Add flank component diagram #1733

Merged
merged 1 commit into from
Mar 24, 2021
Merged

docs: Add flank component diagram #1733

merged 1 commit into from
Mar 24, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Mar 24, 2021 •
edited
Loading

Fixes #1510

component diagram

The architecture model above is based on well-known PresentationDomainDataLayering proposed by Martin Fowler.

Basing on the model above will be easy to:

  • scale the presentation layer by adding necessary implementations.
  • replace external data providers.
  • separate third-party library code from the domain, for keeping code clean.
  • consider each layer as a separate module if needed.
  • deliver output builds for different configurations.
  • deliver domain layer even as a standalone library.

@jan-goral jan-goral self-assigned this Mar 24, 2021
@github-actions
Copy link
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jan-goral jan-goral changed the title doc: Add flank-component-diagram.puml doc: Add flank component diagram Mar 24, 2021
@github-actions github-actions bot added Documentation Pull request which touches documentation Tech Debt labels Mar 24, 2021
@mergify
Copy link

mergify bot commented Mar 24, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@github-actions
Copy link
Contributor

Timestamp: 2021-03-24 10:07:11
Buildscan url for ubuntu-workflow run 682633117
https://gradle.com/s/v5fmfhbjxzpuu

@mergify
Copy link

mergify bot commented Mar 24, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@jan-goral jan-goral changed the title doc: Add flank component diagram docs: Add flank component diagram Mar 24, 2021
@mergify mergify bot merged commit 19ff90f into master Mar 24, 2021
@mergify mergify bot deleted the 1510_Prepare_flank_architecture_diagram branch March 24, 2021 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@zuziaka zuziaka zuziaka approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

@Sloox Sloox Awaiting requested review from Sloox

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

Assignees

@jan-goral jan-goral

Labels
Documentation Pull request which touches documentation Tech Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare flank architecture diagram
3 participants
@jan-goral @zuziaka @pawelpasterz